Unamed Bots

I get the same problem. Everything seems normal until I turn off detailnames. Then every bot is [#]Unnamed. I turn it back on and it pulls names out of the txt file like it should.

One other thing I have noticed is that when the server cycles to a new map, the bots names will look like [POD] [POD] botname (67) (67). Everytime the map changes it adds another iteration of [POD] (skill) to the name. This may have been brought up before, but when I search for [POD][POD] I get nothing because of the braces.

[sPlOrYgOn]

please start a new thread for a new bug.
and the Unnamed problem is fixed..
I'ma test your bug but please start a new thread.
[edit]
yes this does indeed happen
i'll see if i can find the problem
[/edit]

[Pierre-Marie Baty]

Oh I see. It occurs only when detailnames are off. I bet I know where this bug is, then.

Line 330 of bot.cpp

change

		 strncpy (c_name, bot_name, 32);

to

		 strncpy (c_name, szBotNames[name_index], 32);

My bad.

*edit* didn't see how late I was... sPlOrYgOn already fixed the bug. Congrats mate

*EDIT 2*
While I'm here, I've just caught another one on the fly.
Would you mind changing:

// a name has been given
else
{
   // If Detailnames are on, attach Clan Tag
   if (g_bDetailNames)
   {
	  if (iPersonality == 0)
		 sprintf (c_name, "[POD]%s (%d)", bot_name, skill);
	  else if (iPersonality == 1)
		 sprintf (c_name, "[P*D]%s (%d)", bot_name, skill);
	  else
		 sprintf (c_name, "[P0D]%s (%d)", bot_name, skill);
   }
   else
	  strncpy (c_name, bot_name, 32);
}

to

// a name has been given
else
{
   // If Detailnames are on, see if we NEED to attach Clan Tag
   if (g_bDetailNames)
   {
	  if ((strstr (bot_name, "[POD]") != NULL)
		  || (strstr (bot_name, "[P*D]") != NULL)
		  || (strstr (bot_name, "[P0D]") != NULL))
	  {
		 strncpy (c_name, bot_name, 32);
 
		 if (iPersonality == 0)
			c_name[2] = 'O';
		 else if (iPersonality == 1)
			c_name[2] = '*';
		 else
			c_name[2] = '0';
	  }
	  else
	  {
		 if (iPersonality == 0)
			sprintf (c_name, "[POD]%s (%d)", bot_name, skill);
		 else if (iPersonality == 1)
			sprintf (c_name, "[P*D]%s (%d)", bot_name, skill);
		 else
			sprintf (c_name, "[P0D]%s (%d)", bot_name, skill);
	  }
   }
   else
	  strncpy (c_name, bot_name, 32);
}

this is to avoid bots called [POD][P0D][P*D]bot_name (80) (96) (77)" after several map changes.

*EDIT 3* ....and yet another one to display the new personality tags correctly. yee-haw.

*EDIT 4* I should test my bugfixes too before submitting them. :o This one compile correctly now.

It would probably be cleaner to set the clan tags directly in the BotCreateTab, BEFORE calling BotCreate(), and to define the bot personality there. I'll let this up to you

[SoUlFaThEr]

whos making an officials release of these fixes.......

and please put a date on it........the download is always named the same so who knows whats going on

T-anks

[biohazerd87]

well the only reason my folder is such a mess is cause i just draged all the files from the ZIP to the folder most of those files are WP that i already had and i didn't feel like deleting them lol yes i am lazy and is anyone going to realese a new release or is it already there

[sPlOrYgOn]

I already have the unnamed bot bug fixed in my release but not that multiple detail names thing...
I say we add a new arg to allow specifying what personality you want the bot

[Pierre-Marie Baty]

Are we waiting a few more bugfixes ? If you want to release new things every 2 days I'd rather give up my role of "committer" then...

[Huntkillaz]

new realease?

i don't think there's enuff new bugs for another one.....
need more bugs

[sPlOrYgOn]

well I release things to keep people happy so they have the fixes to the bugs they found. So they can start playing without the bug.
My releases should be called unstable

[biohazerd87]

no don't get me wrong i was just wondering if you guys where putting out a new version it is fine with me i just wanted to know. oh and by the way Soul your new waypoint manager kicks ass and i love the new flags they are sweet keep up the good work!