hey stefan...

[Whistler]

okay, forget about this GPL thing if you don't like it. And that's also not on topic - I started this post to help you with the Realbot. And I'm just saw both you and PM have some misunderstanding with the GPL, I just wanted to make things clear. Sorry.

now back to my first intent:

Here's some suggestions to Realbot:
- Use a switch to toggle on/off that Parabot-like autowaypointing function. IMHO when I have played the map for quite a long time the autowaypointing thing is just unnecessary then and just a waste of CPU power.
- Use malloc() for these things may take less memory:

private:
    tNode Nodes[MAX_NODES];	// Nodes
  tInfoNode InfoNodes[MAX_NODES];	// Info for Nodes
  tPlayer Players[32];		// Players to keep track off
  tGoal Goals[MAX_GOALS];	// Goals in the game
  tMeredian Meredians[MAX_MEREDIANS][MAX_MEREDIANS];	// Meredian lookup search for Nodes
  int iPath[32][MAX_PATH_NODES];	// 32 bots, with max waypoints paths
  int iMaxUsedNodes;
  //byte        iVisTable[MAX_NODES][MAX_NODES];
  byte iVisChecked[MAX_NODES];
  unsigned char *cVisTable;
  tTrouble Troubles[MAX_TROUBLE];

eg, first malloc() 512 or 1024 slots, and when it's not enough, realloc() to increase it. IMHO using these static array just takes a lot of unnecessary memory.
- Compress the waypoint data to make the file smaller. There is a good compress code in the PODbot code, maybe you can make use of it.

(also sorry for post these things not in organized way - but I don't think I can become a Team member because I can't work on Realbot that much. And I did learnt something in your code so thanks a lot)

[stefanhendriks]

at the moment the nodemachine is static, and its on purpose static... Although i understand this eats memory. It also ensures its all memory that its needed. I also don't have to worry about bad allocations yet. I am not good at handling dynamic memory. most stuff is btw only a few K of memory so i don't think this should be considered 'critical'..

what did you learn from the code?

[Whistler]

C_DLLEXPORT int
GetEntityAPI2 (DLL_FUNCTIONS * pFunctionTable, int *interfaceVersion)
{
  gFunctionTable.pfnGameInit = GameDLLInit;
  gFunctionTable.pfnSpawn = Spawn;
  gFunctionTable.pfnClientConnect = ClientConnect;
  gFunctionTable.pfnClientDisconnect = ClientDisconnect;
  gFunctionTable.pfnClientPutInServer = ClientPutInServer;
  gFunctionTable.pfnClientCommand = ClientCommand;
  gFunctionTable.pfnStartFrame = StartFrame;
  memcpy (pFunctionTable, &gFunctionTable, sizeof (DLL_FUNCTIONS));
  return (TRUE);
}

C_DLLEXPORT int
GetEntityAPI2_Post (DLL_FUNCTIONS * pFunctionTable, int *interfaceVersion)
{
  gFunctionTable.pfnGameInit = GameDLLInit;  
  gFunctionTable.pfnSpawn = Spawn_Post;
  gFunctionTable.pfnClientConnect = ClientConnect;
  gFunctionTable.pfnClientDisconnect = ClientDisconnect;
  gFunctionTable.pfnClientPutInServer = ClientPutInServer;
  gFunctionTable.pfnClientCommand = ClientCommand;
  gFunctionTable.pfnStartFrame = StartFrame;
  memcpy (pFunctionTable, &gFunctionTable, sizeof (DLL_FUNCTIONS));
  return (TRUE);
}

...looks like you don't know what these two functions mean.
The hooks in GetEntityAPI2 are called *BEFORE* the real gamedll funcs get called, and those in GetEntityAPI2_Post are called *AFTER* the real gamedll funcs get called. So in this way all of YOUR functions in the plugin are called _twice_ when one of the gamedll funcs gets called by engine.

So the GetEntityAPI2_Post should be only like this:

C_DLLEXPORT int
GetEntityAPI2_Post (DLL_FUNCTIONS * pFunctionTable, int *interfaceVersion)
{
  gFunctionTable_post.pfnSpawn = Spawn_Post; // need to declare another gFunctionTable_post in the top of the dll.cpp file
  memcpy (pFunctionTable, &gFunctionTable, sizeof (DLL_FUNCTIONS));
  return (TRUE);
}

[stefanhendriks]

i know the Post function is called AFTER the gamedll functions. And this is on purpose btw. PMB once posted a fix for bots not seeing through all glass/windows. I simply copied the entire function, i did not comment out some parts, this could be done though. Its more like lazyness

[Whistler]

"And this is on purpose btw."
...then IMHO you are doubling the cost of CPU powers, the chance of server crashes and creating some memory leaks "on purpose".

[stefanhendriks]

well, the fact that some functions do get called twice is on purpose , to fix a bug as stated before Anyhow, there is no point in causing memory leaks and doubling cpu power on purpose, unless your name is Microsoft (moving this thread to the RealBot "source" forum)

[Pierre-Marie Baty]

My fix for the glass bug was not to call the same function twice! You misunderstood it I see.

You mustn't call the same function twice, you must call 2 DIFFERENT, SUCCESSIVE HOOKS, for the Spawn() function.

The first hook occurs BEFORE the actual Spawn() function from the gameDLL is called: it's the normal hook your code already uses. It tells you that an entity is about to be spawned. This hook is declared in metamod's gFunctionTable.

The SECOND hook, which IS the fix, occurs AFTER the actual Spawn() function from the gameDLL is called, in order to "correct" one parameter in the entity which has just been spawned. And since we want to do this AFTER the entity has spawned, we must then declare it in metamod's gFunctionTable_Post table.

Whistler is completely right, and your GetEntityAPI2_Post function should be just like what he says. There has never been any "purpose" in calling the same functions twice but to produce horrible things like memory leaks, array indices getting out of bounds, and general fuckups everywhere. I'm starting to be more and more convinced that RealBot is driven by magic! o_O

[stefanhendriks]

Lol. Well yeah, i do learn from Harry Potter a lot I will fix this thing asap.

[stefanhendriks]

Hmm, one question though:

C_DLLEXPORT int
GetEntityAPI2_Post (DLL_FUNCTIONS * pFunctionTable, int *interfaceVersion)
{
gFunctionTable_post.pfnSpawn = Spawn_Post; // need to declare another gFunctionTable_post in the top of the dll.cpp file
memcpy (pFunctionTable, &gFunctionTable, sizeof (DLL_FUNCTIONS));
return (TRUE);
}


this code , which is from Whistler in the above post, it has in the last line:
memcpy (pFunctionTable, &gFunctionTable, sizeof (DLL_FUNCTIONS));


shouldnt it be:
memcpy (pFunctionTable, &gFunctionTable_post, sizeof (DLL_FUNCTIONS));

?

[Whistler]

yeah, that's a typo error