Sandbot v0.3.1

[The Storm]

It looks okay, yes.

[tschumann]

Thanks! Actually, is my problem that all API calls need a RETURN_META or RETURN_META_VALUE? Whatever documentation I read last time didn't mention it but looking http://metamod-p.sourceforge.net/doc/html/coding.html it looks like everything in enginefuncs_t, GetEntityAPI and GetNewDLLFunctions should have a RETURN_META or RETURN_META_VALUE - is that right? Do I need to worry about OVERRIDE or SUPERCEDE?

[The Storm]

Yes, you must return meta results and yes you need to worry about OVERRIDE and SUPERCEDE. The Metamod documentation says well how they are used. Please bare in mind that I upgraded the project file to VS 2015, I don't have older VS, so you will have to upgrade also.

I created a pull request with my changes. Please compile and test it out before accepting it. The bot can be used with or without Metamod now so everyone should be happy.

P.S. I upgraded the FakeClientCommand() function to more modern one used by most of the bots here, now you can use it as the original engine ClientCommand().

EDIT: I just fixed some nasty issue that I missed out. Pull again from the branch using the git pull --rebase command, because I amended the commit.

[tschumann]

Thanks so much! I've had a look at the code and it all looks good (and reminds me how much I need to tidy it all up).
I've pushed up a patch to add Visual Studio 2008 support (I've got a bunch of other stuff that I don't want to upgrade yet and the Source SDK only works with Visual Studio 2013 or earlier).

I'll test it out next weekend.

Thanks again!

[The Storm]

I made another push with some optimizations. I don't have VS2008 but I think that I updated the VS2008 project files properly.

Also there is no issue to have multiple Visual Studios installed on your box. You can install VS2015 side-by-side with VS2008 and all will be fine.

Also I think that the SourceSDK shouldn't be too hard to port to VS2015.

[The Storm]

I've pushed several more changes that fixed wrong function calls to the gamedll when the bot is loaded as Metamod plugin. I hope that there will be no more issues.

[tschumann]

Thanks, I gave it a go today with Half-Life and it all seemed to work just fine (though the bots seemed a lot more violent - maybe I'm just imagining things). I'll hopefully do some more testing with other games/mods and on Linux next weekend then merge it in.
How do I properly test MetaMod anyway? Everything seemed to work but I don't know what kind of problems I should expect.

And yeah, I might go down the path of multiple Visual Studio installs. Need more time...

[The Storm]

Well, there is no some strong path to test if Metamod is working fine. If the bots join fine and play well it should be ok.

Also test it in non-metamod mode, because I made it with dual compatibility. Normal Metamod plugins cannot be loaded without Metamod but I made Sandbot in a way that it should work in both modes.

About the bots been more violent - I have nothing to do with that.

[tschumann]

Yeah okay - still, the code looks fine so I guess it should work.
I tested it without MetaMod too and it ran fine too.

Many thanks!

[The Storm]

You are welcome.