Important! :P Player Model Search bug fix

[Cheeseh]

Heya

I've been having trouble with my bots not adding ALL of the available player models to their list of available models to select.

I found a "bug" in the FindDirectory code of good ol' botman's directory searching I used from HPB_bot code.

The bug is that it kept skipping some directories with me, and did not work as expected.

this

      while ( pFindFileData.dwFileAttributes != FILE_ATTRIBUTE_DIRECTORY )
      {
         if (FindNextFile(hFile, &pFindFileData) == 0)
         {
            FindClose(hFile);
            hFile = NULL;
            return hFile;
         }	 
      }

should be this

      while ( (pFindFileData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) != FILE_ATTRIBUTE_DIRECTORY )
      {
         if (FindNextFile(hFile, &pFindFileData) == 0)
         {
            FindClose(hFile);
            hFile = NULL;
            return hFile;
         }	 
      }

it didn't take into account that a directory could have several more flags set on it (e.g. Read only/Archived etc)

ps you need to update two of these in the FindDirectory() function...


() 8D

[Pierre-Marie Baty]

Thanks!
That's been marked to be put into the next HPB_bot update (if ever there is one...)

[Austin]

Originally Posted by Cheeseh

Heya
I found a "bug" in the FindDirectory code of good ol' botman's directory searching I used from HPB_bot code.

should be this

while ( (pFindFileData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) != FILE_ATTRIBUTE_DIRECTORY )

Well.. not quite..
It MAY work but this would be by-chance.

dwFileAttributes is a bit mask and we are testing for the bit
FILE_ATTRIBUTE_DIRECTORY,

Thus we AND them but then TEST FOR 0 OR NON 0.

if (!(fd.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY))
//code looking for files go here..

if ((fd.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY))
// code looking for dirs go here..

>edit<
Yup, yup, you guys are correct.
Either way will work, but if you want to use positive logic you have to do it your way.

[Pierre-Marie Baty]

Actually Austin...

while ( (pFindFileData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) != FILE_ATTRIBUTE_DIRECTORY )

is the exact equivalent to

while (!(pFindFileData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY))

so Cheeseh's code WILL work after all...

[Cheeseh]

Yup. When you use bitwise operators you don't get a boolean, you get the resulting bitmask. It just so happens that the resulting bit mask is also a number And if the one thing you were testing it against was found then it should equal the same thing.