.:: Bots United ::.

.:: Bots United ::. (http://forums.bots-united.com/index.php)
-   Releases, Installers, Docs & Coding (http://forums.bots-united.com/forumdisplay.php?f=48)
-   -   bot_sounds.cpp (http://forums.bots-united.com/showthread.php?t=1810)

Huntkillaz 30-05-2004 04:50

bot_sounds.cpp
 
there's 3 distinctive lines that's being used over n over

i was wondering if u put it into a method that gets called instead

it would be neater code.. but will it slow\use more resources (ie memory\cpu)?

sPlOrYgOn 30-05-2004 05:39

Re: bot_sounds.cpp
 
yea but i think for 2 different if's it won't be called..
so i think he was trying to save cpu usage at the expense of the dll's size.

Pierre-Marie Baty 30-05-2004 15:07

Re: bot_sounds.cpp
 
...or he was just lazy and did a lot of CTRL-C CTRL-V :)

Huntkillaz 31-05-2004 05:07

Re: bot_sounds.cpp
 
so the bot_sounds.cpp can be reduced file size alot by adding a method similar to this:

Code:

  void SoundMethod(boolean a,float b, float c, boolean d)
  {
            if(a){
                    if ((iIndex < 0) || (iIndex >= gpGlobals->maxClients))
                          iIndex = UTIL_GetNearestPlayerIndex (VecBModelOrigin (pEdict));
            }
                    clients[iIndex].fHearingDistance = b * fVolume;
                    clients[iIndex].fTimeSoundLasting = gpGlobals->time + c;
                  if(d)
                          clients[iIndex].vecSoundPosition = pEdict->v.origin;
                    else
                            clients[iIndex].vecSoundPosition = vecPosition;
  }

and having 1 method call at each place instead of 3-5 lines?

but will it be efficient??

sPlOrYgOn 31-05-2004 05:19

Re: bot_sounds.cpp
 
actually it'll be very very very slightly less efficient but it'll save space in the dll...
at least thats what i think it'll do..

btw...
more descriptive names...
and I don't see iIndex or fVolume or pEdict or vecPosition defined anywhere in that scope...

Huntkillaz 31-05-2004 05:46

Re: bot_sounds.cpp
 
Quote:

Originally Posted by sPlOrYgOn
actually it'll be very very very slightly less efficient but it'll save space in the dll...
at least thats what i think it'll do..

btw...
more descriptive names...
and I don't see iIndex or fVolume or pEdict or vecPosition defined anywhere in that scope...

scope as in the paramaters of the method??...lol i wrote what the code would look like ..not the actual code :o... still learning whats whato_O

sPlOrYgOn 31-05-2004 05:54

Re: bot_sounds.cpp
 
hmm
I dunno of any way to teach you what a scope is but to show you...
Code:

#include <iostream>
using namespace std;

namespace blue
{
  int x = 3;
}

int x = 2;

int main ()
{
  int x = 0;
  {
      int x = 1;
      cout << "This is the value of x: " << x << endl;
      cout << "No.. this is.... " << blue::x << endl;
      cout << "Geez idiots this is.. " << ::x << endl;
  }
  cout << "You're all wrong.. this is.. " << x << endl;
  return (0);
}

well thats a little scope thingy...

Huntkillaz 31-05-2004 23:32

Re: bot_sounds.cpp
 
ahhhh...u mean class.......sorry as i said i've only learnt a little java...and c\c++ is like going to lower langs..

basically this is a method thats within the bot_sounds.cpp if u have a look u'll see that these 5 lines are often used...so to save space one can replace the 3-5 lines with just 1 method call...

i'll try do it and put it up....

sPlOrYgOn 01-06-2004 06:54

Re: bot_sounds.cpp
 
I say we go and add more hearable sounds...
it seems to be like it's missing some useful sounds..

Huntkillaz 05-06-2004 02:04

Re: bot_sounds.cpp
 
yep ur right ..knife hit's and stabs aint there... world spawn...

what other's do we need?


All times are GMT +2. The time now is 06:59.

Powered by vBulletin® Version 3.8.2
Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.